IE8 bug + demo on github + demo js not minified
jeromedecoster opened this issue · comments
Hello,
The demo doesn't works on IE8
http://larsjung.de/fracs/demo/
Strange but : jquery throw an error in IE console (access to unknown property):
Agent utilisateur : Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; GTB7.1; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0)
Horodateur : Thu, 11 Aug 2011 12:02:03 UTC
Message : Demande d'accès à la méthode ou aux propriétés inattendue. (quick translation : access to unknown property)
Ligne : 17
Caractère : 28691
Code : 0
URI : http://larsjung.de/fracs/demo/js/lib/jquery.min.js
I have 2 suggestions:
- put the demo in the github source : https://github.com/lrsjng/jQuery.fracs (I needed to download demo files by hand)
- for the demo, don't use jquery, moderniz minified. It's difficult to track errors.
Thanks!
Hi
and thanks for your feedback!
I don't know if I understand you right?
The demo is already included here under src/demo. You can simply replace the the entries in index.html to unminified version.
Feel free to tell me if I got something wrong here...!
Thanks
Lars
Hello,
I saw the src/demo. But When you just download the files, launch src/demo/index.html, you have:
a blank page, no style
with text like: %BUILD_NAME% %BUILD_VERSION% Demo
no .less compiled files
no running demo like here :
http://larsjung.de/fracs/demo/
My little suggestion is just to also put the final generated files (like on the running demo http://larsjung.de/fracs/demo/) in the github files. Like in a deploy or a bin folder. It's easier for people discovering your plugin.
J.
Ah okay, I see. Does the release folder help with that? There are zipped packages with the compiled demo. But they have still the minified css and js in it. But maybe that's a first step. Will change that to unminified versions in the next release. At least for non lib scripts. Thanks
Of course the release folder is perfect for that. Thanks for the upcoming change!
J.