Giters

lra / mackup

Keep your application settings in sync (OS X/Linux)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Emacs.d folder still backed up even though Emacs application is added to the ignore list

shivams opened this issue · comments

commented

I have added "emacs" to my ignore list by adding the following to my mackup.cfg file:

[applications_to_ignore]
vim #For I am using SpaceVim
emacs #For I am using Doom Emacs

And yet, the emacs.d folder is synchronized. Is this a bug or am I doing something wrong?

commented

Can we see all of your mackup.cfg file? You'll also want to make sure it's located at the home directory and include a . at the beginning of the file before running any mackup commands (i.e. ~/.mackup.cfg)

commented

Yes, my mackup config is in the right location (i.e. ~/.mackup.cfg). And mackup indeed uses the config file since it's using the correct folder to backup/restore as mentioned in the config. Here is the full config:

[storage]
engine = file_system
path = Documents/BACKUP/MackupBackups
directory = legion_22.04

[applications_to_ignore]
vim #For I am using SpaceVim
emacs #For I am using Doom Emacs
commented

Okay, thanks. Is it ignoring vim?

Perhaps it's detecting doom-emacs, try adding that to your applications_to_ignore.

Also, try removing the inline # comments. We may not support that (I haven't seen the source code).

commented

And yet, the emacs.d folder is synchronized

Just a guess, but if you ran mackup backup before adding emacs to your [applications_to_ignore], then you may need to:

  1. verify that ~/.emacs.d is an alias to ~/Documents/BACKUP/MackupBackups/.emacs.d or that ~/.emacs.d doesn’t exist
    1. but if it’s there, then remove the alias at ~/.emacs.d
  2. restore Mackup’s copy of .emacs.d to $HOME
    1. and you may also need to do the same with ~/Documents/BACKUP/MackupBackups/.emacs1 if it exists.

Footnotes

  1. https://github.com/lra/mackup/blob/7c3e232737ef6004d7c540ded6a9e0d75e18443d/mackup/applications/emacs.cfg ↩

commented

Thank you guys for your prompt responses. As @joshmedeski pointed out, the inline # comments were indeed causing the issue. Mackup was also backing up the .vim folder but since it was softlinked to .SpaceVim folder, I wasn't aware of it. So, having those inline comments effectively made those lines useless. I first uninstalled the mackup (mackup uninstall, then removed those inline comments, and then did the backup again (mackup backup). And voila! emacs.d folder was not backed up anymore.

commented

I think mackup should show some warning if it's not able to parse some of the configuration properly. In this case, it should have issued me some warning that it can't recognize the applications that it is supposed to ignore as per the config file.

If you feel, this issue can be re-opened or a new issue created based on this feature request that mackup should show warning in case of faults in the config

commented

Thanks for the feedback. I've added a new issue to add support for inline comments in the config file.