Consider merge up to https://github.com/rust-unofficial/patterns
tesuji opened this issue · comments
Hey, I'm one of the maintainers of said repository and I think it would make sense to "merge" this repository as we are working on bringing rust-unofficial to rust-lang. What's your opinion on this @lpxxn ? Umbrella issue is here: rust-unofficial/patterns#116
it's ok. but how to do this, copy all code to rust-unoffical/patterns ?
it's ok. but how to do this, copy all code to rust-unoffical/patterns ?
Hmm, as we have CI checks in place and we (maintainers) and others want to read over what is being merged into the repository it might be best, if we (I can help you there) open PRs for each pattern. I know it sounds like a lot of work, but we'll manage and it will be for the good. :)
Also another question is the differences in licensing. Patterns is licensed under MPL-2.0 whereas contents of this repository are licensed under GPLv3. It might make sense to state in each PR then, that you relicense the PRed content under MPL-2.0 for the patterns repository.
If you agree I can start creating PRs for each of the patterns. :)
I've reorganized the structure of the patterns repository so we can easier PR these patterns into their corresponding categories in rust-unofficial/patterns#219
We should also be aware, that some Patterns might need changes, as we follow our template style. But filling that out we can do collaboratively with the user base. Might be better, if I PR them though. 🤔 If you are willing and stating to relicense the content in the corresponding PRs. So it's overall less work for you :)
@lpxxn Some of the patterns here felt like directly taken from another language which does not seeemed fit so well in rust which is probably the reason why it wasn't included in the rust patterns at first. One reason could be ergonomic. We should think twice before including all of them, maybe some might be good like State (although the example isn't good), but some others looked a bit weird (lots of dyn), then we are on the road to do more reflection magic and remove the compile time safety rust provides.
Imagine having lifetime, borrowing, ownership pattern in java, what would happened?
@simonsan Please try to make sure we have a good example or even better, it is a pattern being used in a popular crate, then I would say it is good to merge it, otherwise it feels weird to have a hard direct port.
@lpxxn Thank you :)
The point is, sometimes people just miss examples to write the corresponding articles, I did it now in the way, that I opened an issue for every missing article that we find examples in here and used them. My hope is, that more people write some articles about these patterns in the future because of the reason that they easily found an example for it, that they could still improve, if they wanted to. So @lpxxn @pickfire don't worry, we won't merge it into the repository immediately. But as examples to discuss about and improve upon together they are really nice.