prometheus metric `monitor_cert_days_remaining` missing after update to 1.23.12

[Stefan Gerasch]

📑 I have found these related issues/pull requests

• #4693
• #2455

🛡️ Security Policy

• I agree to have read this project Security Policy

Description

after update to 1.23.12 monitor_cert_days_remaining is not exported anymore, it is still shown in the dashboard.

👟 Reproduction steps

use 1.23.12 and create monitor for an https website

👀 Expected behavior

monitor_cert_days_remaining is exported as in version 1.23.11

😓 Actual Behavior

the monitor_cert_days_remaining metric is missing

🐻 Uptime-Kuma Version

1.23.12

💻 Operating System and Arch

debian/docker

🌐 Browser

chrome

🖥️ Deployment Environment

• Runtime: Docker 24.0.7
• Database: embedded
• Filesystem used to store the database on:
• number of monitors: 5

📝 Relevant log output

No response

[Frank Elsinga]

Are you using a proxy or plain http?

[Stefan Gerasch]

Plain https

[Frank Elsinga]

This bug was likely introduced by #4630 and is likely caused by a timing issue between

uptime-kuma/server/model/monitor.js

Lines 517 to 519 in e797abd

 options.httpsAgent.on("keylog", (line, tlsSocket) => { 
     tlsInfo = checkCertificate(tlsSocket); 
 }); 

and

uptime-kuma/server/model/monitor.js

Line 1013 in e797abd

 this.prometheus?.update(bean, tlsInfo); 

[Krafting]

I have a dashboard in grafana, and I don't have the stats (for the metrics below) anymore since the Update

monitor_cert_is_valid and monitor_cert_days_remaining