Issue with detecting language with 3 letter code
searinminecraft opened this issue · comments
📑 I have found these related issues/pull requests
I don't seem to find any related issue.
🛡️ Security Policy
- I agree to have read this project Security Policy
Description
When the system or web browser is set to a language with three letters (e.g. Filipino, which is fil), it only parses the first two (fi) and would automatically assume it's that language (which is Finnish in this case) and chooses that one instead. Since there is no Filipino translation yet, I would expect it to fall back to English, but not in this case because of the issue.
Screenshot:
👟 Reproduction steps
As far as I know, only Chromium has the option for the Filipino language, so use that instead if you can
- Set the preferred language to Filipino on
chrome://settings/languages, make sure its at the very top. - Visit any Uptime Kuma instance, like https://status.codeberg.eu or the demo version provided in the README
👀 Expected behavior
Since there is no Filipino translation yet, it should fall back to English
😓 Actual Behavior
Uses the Finnish language instead
🐻 Uptime-Kuma Version
1.23.12
💻 Operating System and Arch
Arch Linux
🌐 Browser
Chromium 122.0.6261.111
🖥️ Deployment Environment
Not applicable
📝 Relevant log output
No response
Who would have thought that language detection is such a hard problem.
You got to be kidding me..
I don't think the problems are solved yet, suddenly uptime is showing the UI in Polish every time I reload when I need English.
Unsurprising as the PR that fixed the issue #4692 is not yet released to allow for fixing the proxy/metrics issues at the same time.