[groups] pausing groups does show children as paused without pausing them
Tealk opened this issue · comments
📑 I have found these related issues/pull requests
🛡️ Security Policy
- I agree to have read this project Security Policy
Description
If you pause the folder, the underlying elements are also displayed as paused, but notifications are still sent.
👟 Reproduction steps
Create a folder and a child element
Add a notification to the child element
Pause the folder
create an error
👀 Expected behavior
no notification is sent because all elements are paused
😓 Actual Behavior
notifications are sent
🐻 Uptime-Kuma Version
1.23.12
💻 Operating System and Arch
Debian 12 (bookworm)
🌐 Browser
Firefox 125.0.1 (64-bit)
🖥️ Deployment Environment
- Runtime: docker
- Database: sqlite
- Filesystem used to store the database on: ZFS
- number of monitors: 42
📝 Relevant log output
No response
| paused | unpaused |
|---|---|
 |
 |
Could you provide a concrete example how to test this?
Groups work mostly as expected in the experiment I ran..
Yes, they tick on (that is a bug) but they record all heartbeat as UP => no notifications
Could you provide a concrete example how to test this?
I have indicated above how it can be reproduced, or what exactly is the question?
Or am I misunderstanding the pause function, I thought it would not be checked further and therefore no notification would be sent.
Please see my screenshots:
I can't reproduce your steps... => need a concrete example how to test this
as you can see in my screen i have 3 checks in one folder, i paused the folder because i restarted the server on which the 3 are running so that no notification comes.
But it was still checked and a notification was issued.
Okay, somehow my testing mechanism was a bit flawed.
I re-tried reproducing it on https://uptime.kuma.pet/ monitoring https://beeceptor.com/ was able to do so.
if there is anything I can do, please let me know
I would love to have a contributor debug this.
I currently don't have the time to spend on that due to personal reasons (writing a bachelor thesis), but do have the time to review PRs.
Our contribution guide is found here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md
Debugging this would require stepping through the code with a debugger and see where/why
- monitors are not getting paused or
- are ignoring being paused