Error in working with local proxy
Druidblack opened this issue · comments
⚠️ Please verify that this question has NOT been raised before.
- I checked and didn't find similar issue
🛡️ Security Policy
- I agree to have read this project Security Policy
📝 Describe your problem
After updating to version 1.23.12, an error was found (Cannot set properties of undefined (setting 'valid') when working with local proxies
Rolling back to version 1.23.11 solved this problem.
I'm launching it in the docker.
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.23.12
💻 Operating System and Arch
Debian (docker)
🌐 Browser
Chrome
🖥️ Deployment Environment
- Runtime: Docker 26.0.1
- Database:
- Filesystem used to store the database on:
- number of monitors:
Had the same problem.
I am also experiencing this issue.
Same problem here.
Add me to the list... very annoying, since I have to use the proxy in order to make IPv6 funtion at all under Docker.
What do you mean concretely when you say "when working with local proxy"?
As for me, I monitor a https URL which resolves to an IPv6 address and thus I use a "local" (as in: my own RFC1918 network) squid proxy which is reachable via IPv4.
Not what I was fishing for: where does the error occur?
On the dashboard log for the http(s) monitoring entry and in the container log as well:
2024-04-19T12:55:17+02:00 [MONITOR] WARN: Monitor #28 'Internet (IPv6)': Failing: Cannot set properties of undefined (setting 'valid') | Interval: 60 seconds | Type: http | Down Count: 0 | Resend Interval: 0
2024-04-19T12:55:19+02:00 [MONITOR] WARN: Monitor #32 'Internet': Failing: Child inaccessible | Interval: 60 seconds | Type: group | Down Count: 0 | Resend Interval: 0
Internet (IPv6) is the name of the monitoring item, Internet is the group it is in.
Reverting to 1.23.11 indeed fixes the problem.
Container log stays empty w/r to this with that version.
I would be willing to increase the log level, but I do not know how or if that helps.
What do you mean concretely when you say "when working with local proxy"?
Using gluetun, I make myself a local proxy server.
@CommanderStorm : You were right about line number 536 in 'server/model/monitor.js'. When I comment that out, everything works again. I just added a comment to your review...
I think I understand how the error can occur, but strangely I can't reproduce this using a squid proxy connecting over HTTP. What is the protocol used connecting to the proxy when the error occurs?
I think I understand how the error can occur, but strangely I can't reproduce this using a squid proxy connecting over HTTP. What is the protocol used connecting to the proxy when the error occurs?
HTTP
I use http to connect to the Squid proxy and the monitored URL is https. I think it is exactly this which causes the problem, as I wrote here: #4630 (comment)
Okay, I'll implement the fix later today.