Preview is rendered wrong in dark mode

Question

Preview is rendered wrong in dark mode

LeoNatan opened this issue 6 years ago · comments

To reproduce, quickly tap the Add button, type a short word and tap Done.
After editing several times, it becomes fully white as expected.

Léo Natan · Answer 1 · Sat Mar 17 2018 19:34:10 GMT+0800 (China Standard Time)

Not sure if this is a UIKit bug.

Louis D'hauwe · Answer 2 · Sat Mar 17 2018 20:36:05 GMT+0800 (China Standard Time)

I believe this is a UIKit bug.

Louis D'hauwe · Answer 3 · Sat Mar 17 2018 20:37:11 GMT+0800 (China Standard Time)

I heard iOS 11.3 will fix a lot of bugs in UIDocumentBrowserViewController, hopefully fixes this glitch.

Léo Natan · Answer 4 · Sat Mar 17 2018 20:42:31 GMT+0800 (China Standard Time)

I use 11.3 😄

Léo Natan · Answer 5 · Sat Mar 17 2018 20:44:43 GMT+0800 (China Standard Time)

How are previews generated? Does the system create the thumbnail or is the app rendering it in an extension?

Louis D'hauwe · Answer 6 · Sat Mar 17 2018 21:07:59 GMT+0800 (China Standard Time)

The system creates it, so out of our control I’m afraid 😕.

Alessandro Saba · Answer 7 · Mon Mar 19 2018 21:09:31 GMT+0800 (China Standard Time)

Yeah, it's just a simple line of code and iOS should automatically set colors, previews, and everything.
It's definitely a UIKit bug

aamct2 · Answer 8 · Wed Apr 11 2018 02:15:59 GMT+0800 (China Standard Time)

If iOS isn't providing correct/good thumbnail renderings, we do have a couple options to work around it.

Option 1

We could manually generate a thumbnail and set the appropriate resource key as part of the save process for the UIDocument. It looks something like:

override func fileAttributesToWrite(to url: URL, for saveOperation: UIDocumentSaveOperation) throws -> [AnyHashable : Any] {
    let thumbnail = thumbnailForDocument(at: url)
    return [
        URLResourceKey.thumbnailDictionaryKey: [
            URLThumbnailDictionaryItem.NSThumbnail1024x1024SizeKey: thumbnail
        ]
    ]
}

This would be the option I'd recommend as we're only handling it for documents that Textor has created/edited and not text documents system wide.

For further reference see:

Option 2

We could support the new thumbnail extension that came with iOS 11. There's an Xcode template for this. Essentially, the core method is:

func provideThumbnail(for request: QLFileThumbnailRequest, _ handler: @escaping (QLThumbnailReply?, Error?) -> Void)

I don't recommend this as we aren't the primary owners of the text UTI type. We aren't dealing with a custom document format, which is what this is designed for.

For further reference see: