Explicitly define in contributing guidelines to make a pull request for dev branch
wulforr opened this issue · comments
Is your feature request related to a problem? Please describe.
Beginners to open source development generally make a pull request in master branch.
Describe the solution you'd like
Define it in contributing guidelines to take steps for pull request and to merge in dev branch.
It could be somewhat like this
Thanks and we saw that many people created PRs for the master branch. In order to make it more easy, we will accept PRs into master by changing the CI process to build on releases. Will keep this open until then and keep it as reference if we still need this.
Please consider mentioning this in the contributing guide until you change the build process, it's very annoying to make a PR against master and then realizing it should be against dev and having to rebase or merge.
If you would be OK with that, I can make a PR updating the contributing guide.
An alternative would be to make dev the default branch in the meantime, as most other projects using git flow do.
Also, what would be the issue with using a continuous deploy model that builds on every merge?
An alternative would be to make dev the default branch in the meantime, as most other projects using git flow do.
How do you configure this on GitHub? I've tried to look into options to not allow PRs to master or to make it clear that if you make a PR it should be to dev (besides CONTRIBUTING.md) but could not find such a thing. So I'm genuinely curious about this.
It's under Settings > Branches:
Great! @lostdesign we could do this in the meantime until we've configured Continuous Deployment to rebuild on releases.
Doing that now.