lost-pixel / lost-pixel

Open source alternative to Percy, Chromatic, Applitools.

Home Page:https://lost-pixel.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stories with same name overwrite each others screenshot

chriskalmar opened this issue · comments

Bug description

Using the same name for 2 or more stories leads to having the same filename.

This function needs to be refactored:
https://github.com/lost-pixel/lost-pixel/blob/main/src/crawler/storybook.ts#L244-L245

How to reproduce

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

Expected behavior

No response

Lost Pixel information

lost-pixel logs from CI

No response

Hello, curious what is the use case here? I am looking into the codebase and found this issue but not sure what would be a way to trigger this..

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

If the file name is different the filename generated by lost pixel will also be different right? In the case that the story has the same name it looks like its already cut off in stories.json?