possible bug?

Question

possible bug?

selamar opened this issue a year ago · comments

/usr/local/bundle/gems/brick-1.0.131/lib/brick/frameworks/rails/engine.rb:98: warning: found `= literal' in conditional, should be ==

Lorin Thwaits · Answer 1 · Wed Apr 19 2023 06:12:28 GMT+0800 (China Standard Time)

warning: found `= literal' in conditional

Not a bug -- but also not elegant that it pops that warning!

Will update to use binding#local_variable_set in order to suppress this warning -- expect a release within 24 hours.

BTW -- thank you for testing Brick with .webp images!

Lorin Thwaits · Answer 2 · Wed Apr 19 2023 14:03:56 GMT+0800 (China Standard Time)

Fixed in v1.0.132.

Thanks much for reaching out!

Sergio La Marca · Answer 3 · Wed Apr 19 2023 16:53:09 GMT+0800 (China Standard Time)

Alas, you make me waaay smarter than I am, I wasn't testing anything and I have no .webp images that I know of. The notice just popped out during the rails server bootstrap, I was looking because I'm trying to learn Rails. Anyway, great job!! Glad to be useful. Sergio Il giorno mer 19 apr 2023 alle ore 00:12 lorint ***@***.***> ha scritto:

…

warning: found `= literal' in conditional Not a bug -- but also not elegant that it pops that warning! Will update to use binding#local_variable_set in order to suppress this warning -- expect a release within 24 hours. BTW -- thank you for testing Brick with *.webp* images! — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWDSTRDH5SRJECU4NB2EXDXB4GVNANCNFSM6AAAAAAXCYGLPU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Lorin Thwaits · Answer 4 · Wed Apr 19 2023 19:04:51 GMT+0800 (China Standard Time)

The notice just popped out during the rails server bootstrap

Well then I'm thankful that you are keenly observant!
Depending on what Ruby version you've got, some of those warnings do or don't appear, so this could be why I hadn't seen this yet.

The Rails community is a wonderful place and I hope you have fun with this great ecosystem!

Sergio La Marca · Answer 5 · Wed Apr 19 2023 19:07:55 GMT+0800 (China Standard Time)

Thanks, you too! Il giorno mer 19 apr 2023 alle ore 13:05 lorint ***@***.***> ha scritto:

…

The notice just popped out during the rails server bootstrap Well then I'm thankful that you are keenly observant! Depending on what Ruby version you've got, some of those warnings do or don't appear, so this could be why I hadn't seen this yet. The Rails community is a wonderful place and I hope you have fun with this great ecosystem! — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWDSTT5AOZSR6ZC7GUO6E3XB7BF5ANCNFSM6AAAAAAXCYGLPU> . You are receiving this because you authored the thread.Message ID: ***@***.***>