lorenzodifuccia / safaribooks

Download and generate EPUB of your favorite books from O'Reilly Learning (aka Safari Books Online) library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Images from books are corrupt

jgarr16 opened this issue · comments

All of the images that are being retrieved from O'Reilly are corrupt. I have tried several books over the course of several days; the only image that downloads in a usable format is the default_cover.jpeg. Other than that, several hundred *.jpg files cannot be opened with any application (i.e., image apps or text apps).

Examples:
https://learning.oreilly.com/library/view/principles-of-computer/9781260474329/
https://learning.oreilly.com/library/view/mike-meyers-comptia/9781260473704/
https://learning.oreilly.com/library/view/mike-meyers-comptia/9781260467963/

The images download something, but the .jpg files are all the same size (29KB in every case) and do not resolve in the resultant .epub. When I try to open any of the .jpg files with various imaging applications, I get an error that looks like this:

  • The file “F07-02.jpg” could not be opened. It may be damaged or use a file format that Preview doesn’t recognize

safaribooks_error

.

I had the same issue which got resolved after pulling the latest code.

then is it working?

I had the same issue which got resolved after pulling the latest code.

@palash247 - thanks; latest version cured all.
@lramosduarte - yes, it's working perfectly.
@lorenzodifuccia - thanks for what you do! Amazing!