lorenzodifuccia / safaribooks

Download and generate EPUB of your favorite books from O'Reilly Learning (aka Safari Books Online) library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add info to readme about ORLY_BASE_HOST for SSO

fredlarochelle opened this issue · comments

As said in the title, info should be added to the readme about a possible reason why SSO might not be working for some folks. In my case, the URL was different than "oreilly.com". I simply changed the value of ORLY_BASE_HOST (line 24 of safaribooks.py) to the correct URL and it started working.

Should I make a pull request for such a simple change to the readme?

I think that for SSO is better what said until now: "use authenticated cookie".
See: README, #150 (comment)

If you don't agree, please reopen this issue!