Deprecated links annotation on compose file

Question

Deprecated links annotation on compose file

thiras opened this issue 5 years ago · comments

Hello.

As you can see here links notation is deprecated already. No need to create links between them since docker create a network between all containers by default.

Would you like to have a PR to fix it?

Robert Guthrie · Answer 1 · Sun Nov 10 2019 04:25:09 GMT+0800 (China Standard Time)

If you're sure things still work after this change, then yes please. I appreciate the support!

Ant Somers · Answer 2 · Mon Nov 11 2019 04:44:06 GMT+0800 (China Standard Time)

I'll take a test from scratch just to be sure nothing is broken after #62 merge.

Robert Guthrie · Answer 3 · Mon Nov 11 2019 06:01:38 GMT+0800 (China Standard Time)

thank you!

…

On Mon, Nov 11, 2019 at 9:44 AM Ant Somers ***@***.***> wrote: I'll take a test from scratch just to be sure nothing is broken after #62 <#62> merge. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=AADWXXZ24K4DCWD3C4CRLG3QTBXBNA5CNFSM4JLITQCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVGIHQ#issuecomment-552231966>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADWXX6GW6ADQJSSWNHMISLQTBXBNANCNFSM4JLITQCA> .