lookfirst / mui-rff

MUI 5 / Material UI + React Final Form

Home Page:https://lookfirst.github.io/mui-rff/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AutoComplete: RFF meta.active not set when user changes values

yann-combarnous opened this issue · comments

Describe the bug
When using the AutoComplete component, the "meta.active" final form property is not set.

It works fine in other components, such as Select or TextField.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Code Sandbox: https://codesandbox.io/s/old-http-0jz3dn?file=/src/App.js
  2. Click on Currencies field (AutoComplete), modify value
  3. look at console log, value of "active" field is "undefined"

Expected behavior

  1. Go to Code Sandbox: https://codesandbox.io/s/old-http-0jz3dn?file=/src/App.js
  2. Click on User field (TextField), modify value
  3. look at console log, value of "active" field is "userName"

Thanks for the report! Ok, I see that. I have zero clue on how to fix it though, do you?

Thanks for the report! Ok, I see that. I have zero clue on how to fix it though, do you?

Have not had a chance to take a look yet, started by doing a simple reproduction.

I guess I would start by comparing the property list received by TextField in AutoComplete component vs the list in the standalone Textfield? I may give it a try later this week, if I get some time. Probably some onFocus listener missing?

Hi any update on this issue?

@ErikParso There is no update until someone decides to come along and help fix it, that's why the issue is still open and you're running across it. Since it is affecting you, would you like to take a stab at fixing it? I can offer whatever support you need to help you. By helping fixing this issue, you're helping out a lot of other developers and contributing something back to the community as a whole. This is a very positive feedback loop for everyone.

😄

Yay everybody taking nobody giving :D Ill take a look

#1079
onFocus and onBlur callbacks were missing in autocomplete field.

fixed in 6.2.3. thanks @ErikParso for the pr!