UploadFileParams uses old paramter: convert_placeholder
chrisdchow opened this issue · comments
Describe the bug
File upload does not respect convert_placeholder
parameter.
To Reproduce
- Use the node-js-api to upload a File.
- Set convert_placeholder to
false
.
await this.lokaliseApi.files.upload(this.projectId, {
data: content,
filename: fileName,
lang_iso: languageISOCode,
convert_placeholder: false,
tags: ['Pushed'],
replace_modified: this.replaceModified,
skip_detect_lang_iso: true,
})
- File in Lokalise uses the Lokalise universal placeholder
Expected behavior
I expect the original placeholder to preserved.
Your environment:
- Node version: 12.22.3
Additional context
UploadFileParams does not use convert_placeholders
which is the correct param in the latest version of the API. https://app.lokalise.com/api2docs/curl/#transition-upload-a-file-post. Rather it uses convert_placeholder
, without the s. I contacted someone on Lokalise support and they mentioned convert_placeholder
is the V1 version of that param.
Hello, thank you for reporting this! I'll fix asap.