logux / server

Build your own Logux server or make a proxy between a WebSocket and an HTTP backend in any language

https://logux.org/

Wrong meta key in Context#sendBack

semenovDL opened this issue 5 years ago · comments

Alexey Kuznetsov commented 5 years ago

Context#sendBack use clientIds as meta keys (https://github.com/logux/server/blob/master/context.js#L107), but BaseServer#sendAction is waiting for meta.clients (https://github.com/logux/server/blob/master/base-server.js#L735)

Andrey Sitnik commented 5 years ago

Thanks, I missed it.

Do you want to send PR to save your name in the project history?

Alexey Kuznetsov commented 5 years ago

@ai sure, I'll send PR. Which one is preferred? clients as for other meta keys?

Andrey Sitnik commented 5 years ago

Yeap, meta.clients is correct