logux / logux_rails

Rails client for Logux server

Home Page:https://logux.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Better error answer

ai opened this issue · comments

Now gem writes ['error', 'message']. We need to write: ['error', meta.id, e.backtrace.join("\n")]

commented

https://cultofmartians.com/tasks/logux-rails-error.html leads here, but I'm not sure if this issue is still present after 6145262. Is it?

@ojab Thanks for the question, you are right, this issue is closed

@dsalahutdinov is that commit send ['error', error.stack]? I saw only ['error', 'Please look server logs for more information'] which doesn’t have error stack and is not good DX (good DX is to show Rails error directly in browser DevTools console by sending ['error', error.stack] to Logux server.

@ojab @ai, yes, we have the lack of backtrace in the error response, reopen back, sorry

@dsalahutdinov только давайте включим это по-умолчанию. Логакс не пошлёт эти ошибки клиентам если запущен в режиме production.