Unnecessary Dependency?
abates opened this issue · comments
I'm curious why logstash-core-plugin-api is included as a runtime dependency in the gemspec?
I don't see that this gem is actually included anywhere. I wanted to write a quick script to test some grok patterns using the baseline patterns in logstash-patterns-core. However, since I don't use jruby and logstash-core-plugin-api has depdencies for several jruby gems I can't use logstash-patterns-core directly.
Can the runtime dependency be removed?
Indeed we could remove the dependency here. The logstash-core-plugin-api helps logstash know which plugins work with which versions of logstash-core without having to update all plugins with new releases of core.
in this case, the logstash-patterns-core ruby code has a very tiny piece of code to interact with core..what do you think @ph?
I have more interrogation:
- Currently, this plugin (or raw text) have the really little dependency on the core.
- Maybe core should provide a more official API to change load path?
- Maybe we should depend on the logstash-filter-grok instead?
- Why this code isn't in the grok filter? Do we need this level of indirection?