Pseudo-Boolean Constraint toString into Parser Roundtrip does not work.

Question

Pseudo-Boolean Constraint toString into Parser Roundtrip does not work.

d-bischoff opened this issue 8 years ago · comments

DB commented 8 years ago

If i parse a pseudo boolean constraint like

1 * A + 1 * B = 1

it works. If I then print this with toString() it becomes

A + B = 1

which can not be parsed anymore.

I believe that output should be parseable again. And it is in all other cases.

Christoph Zengler · Answer 1 · Thu Jul 14 2016 22:15:39 GMT+0800 (China Standard Time)

Absolutely right. The question ist: should

(1) the parser be able to parse A + B = 1 or should
(2) the toString() be 1 * A + 1 * B = 1.

(2) is very easy to implement, (1) would be more elegant to read. Any preferences?

DB · Answer 2 · Fri Jul 15 2016 05:39:33 GMT+0800 (China Standard Time)

Well yes indeed. Exactly my thinking.

Which probably already answers your question. I would prefere Option 1, but as a work around 2 is also fine. Would you agree?

Christoph Zengler · Answer 3 · Sat Jul 16 2016 22:00:34 GMT+0800 (China Standard Time)

OK. I went for the elegant solution :) This will be part of Release 1.1. You can test the implementation in the release_1.1 branch. Please give feedback, if everything works as expected.

DB · Answer 4 · Mon Jul 18 2016 18:34:14 GMT+0800 (China Standard Time)

Will do. Thanks!

DB · Answer 5 · Tue Jul 19 2016 20:49:31 GMT+0800 (China Standard Time)

I have yet to find any problems related to the new parser. Thanks again.