loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications

Home Page:https://loganoz.github.io/horses3d/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implementation of non-3D meshes

Andres-MG opened this issue · comments

The way 2D cases are handled is very confusing I think. These three attributes:

logical :: meshIs2D = .FALSE. ! Is this a 2D mesh? default .FALSE.
integer :: dir2D = 0 ! If it is in fact a 2D mesh, dir 2D stores the global direction IX, IY or IZ
integer :: dir2D_ctrl = 0 ! dir2D as in the control file

are set during the pre-processing stage to a value that depends on the keywords in the control file and the mesh itself. It seems that this is done in this function:
subroutine HexMesh_CheckIfMeshIs2D(self)

but it seems to override the choice of the user in the control file.

I will not merge #158 until this is reviewed, as the characteristic length of the elements is now wrong in 2D cases, and methods depending on it (LES, shock capturing) will provide different results.

I have pinned this issue so we don't forget.