lodash / lodash.com

The Lodash website.

Home Page:https://lodash.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ad appears to (but doesn't) cover content in the left nav, mainly because of scroll bar indicator position

mmarvick opened this issue · comments

When I scroll through the left nav in the documentation, I got tricked into thinking the ad was covering some content that can't be scrolled to. It turned out not to be the case, but I took screenshot of the issues causing confusion below. These issues could probably all be solved by the solution brought up in #147 (making the sidebar and the ad siblings).

Screenshots are from Firefox 67.0.2 on Mac OS 10.14.5, but the behavior is the same in Chrome 75.0.3770.80.

Scroll bar position

The scroll bar goes past the bottom of the list items, aligning to the bottom of the ad. This makes it feel like the scrollable content probably goes to the bottom of the ad as well.


Screen Shot 2019-06-15 at 10 23 11 AM


Screen Shot 2019-06-15 at 10 23 17 AM


Screen Shot 2019-06-15 at 10 14 38 AM

No separation

Visible in the last image above - when you get to the bottom of the list, there's nothing separating the list content from the ad, so it feels like there might be more. A horizontal rule might fix this. But if the scroll bar wasn't going past the content, tweaking this might not be necessary.

_. renders over the ad content

You can see the _. (but not the method name itself) rendering on top of the ad. This gives the allusion that more stuff might be hiding down there.

Screen Shot 2019-06-15 at 10 28 53 AM


Screen Shot 2019-06-15 at 10 16 47 AM

This is by design though if you can fix it I’d except a PR.