lkdm / compoundinterest-react

A compound interest calculator to assist in financial decision making. Created to demonstrate my ability to develop applications in ReactJS, Typescript, and Bootstrap.css.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Code cleanup based on code review

lkdm opened this issue · comments

Code reviewed by another developer.


To do list based on feedback provided:

  • Move types.tsx out of store/ and into a models/ or types/ directory
  • Don't assign default types arbitrarily (ex: Don't use Money, just number)
  • Remove all instances of redux including from package.json, if you are not using it.
  • Move useState out of App.tsx and into a StrategyContext. More information at this tutorial.
  • Write more about the project and dependencies used in README.md
  • Turn Frequency into an enum.