ljharb / actions

GitHub actions I use for CI.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecation warning for `set-output` command

mishina2228 opened this issue · comments

I've just found that the deprecation warning is displayed in the GitHub Actions workflows for eslint-plugin-import.

I believe the following code in this repository has something to do with it, is that right?

} else if (arg.startsWith('::set-output name=cache-hit::')) {
core.info(`hijacking core.setOutput output: ${arg}`);
cacheHit = arg === '::set-output name=cache-hit::true';

} else if (arg.startsWith('::set-output name=cache-hit::')) {
core.info(`hijacking core.setOutput output: ${arg}`);
cacheHit = arg === '::set-output name=cache-hit::true';

Yep, exactly right :-) i haven’t gotten around to fixing it yet because it’s not easy to test (without breaking hundreds of repos).

Altho in this case the warnings are actually because i haven’t updated the github core package past .10 - for the same reason (testing and breakage)

I believe 63baadd has fixed this.