Setting properties for solaris services.

[Mark Gibbons]

I'm building a bunch of new solaris 11 boxes. They need to have service properties set to manage things that used to be in files,DNS name resolution and NSS are two good examples. I'd rather not change settings with bash script resources. Getting the changes to be idempotent is a bit tricky. I'm in the process of adding a setprop action to a fork of this cookbook. Would you be amenable to including such an action if I put in a pull request?

Thanks,
Mark

[Mark Gibbons]

I'm writing my updates in an environment where I need to have mostly clean rubocop, tailor and food critic checks. Running rubocop against the project turns up lots of alignment and quoting call outs. Do you have a strong preference for leaving quoting and formatting alone? I can make a separate version for the pull request, I'd just rather not. My working and mostly tested version of the code is in: https://github.com/MarkGibbons/smf/tree/UIS-822

I added rspec tests for the stuff I added and added serverspec testing for the integration tests.

thanks,
Mark

[Eric Saxby]

I'd actually prefer to have this project green in rubocop and foodcritic. I
disagree with some of the rubocop styles, so I can fix the rubocop errors.
If you don't mind waiting a little bit, I might be able to fix this by this
afternoon.

On Fri, Dec 5, 2014 at 10:48 AM, MarkGibbons [e-mail]
wrote:

I'm writing my updates in an environment where I need to have mostly clean
rubocop, tailor and food critic checks. Running rubocop against the project
turns up lots of alignment and quoting call outs. Do you have a strong
preference for leaving quoting and formatting alone? I can make a separate
version for the pull request, I'd just rather not. My working and mostly
tested version of the code is in:
https://github.com/MarkGibbons/smf/tree/UIS-822

I added rspec tests for the stuff I added and added serverspec testing for
the integration tests.

thanks,
Mark

—
Reply to this email directly or view it on GitHub
#17 (comment).

---

e s

[Mark Gibbons]

No shortage of other things for me to work on so waiting a bit is pretty easy.
Thanks

[Eric Saxby]

Ok, I've pushed a few things, including a Strainerfile. Tailor looks fairly redundant with rubocop, so I think I'll just stay with rubocop unless there's a pressing reason that tailor will keep bugs from being introduced.

I also added notes about contributing... the one thing is I noticed your merged master commits in between several new commits. I try to do fast forward merges of pull requests where possible, so would you be able to rebase your commits after the updates? If not, I can sort it out you issue the pull request.

[Eric Saxby]

I'm closing this issue, as it's now covered here #18