liveservices / LiveSDK-for-Windows

LiveSDK library for integrating with Live Connect

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unhandled NullReferenceException due to missing resource

factormystic opened this issue · comments

The defect is that while ApiOperation can create a LiveConnectException exception for NoResponseData errors...

https://github.com/liveservices/LiveSDK-for-Windows/blob/master/src/Common/Source/Internal/Operations/ApiOperation.cs#L128

...there is no corresponding NoResponseData resource here (and probably the other resource files/platform targets)...

https://github.com/liveservices/LiveSDK-for-Windows/blob/master/src/WinStore/Source/Resources.resx

...so, the following line blows up as a null ref exception because you're trying to grab a resource that doesn't exist...

https://github.com/liveservices/LiveSDK-for-Windows/blob/master/src/WinStore/Source/Internal/ResourceHelper.cs#L46

...thus, NoResourceData errors result in NullReferenceExceptions, which is incorrect.

Wow, that is pretty terrible!