livecycle / preevy

Quickly deploy preview environments to the cloud!

Home Page:https://preevy.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename `preevy down` to `preevy rm`

royra opened this issue · comments

Per feedback from @Pradumnasaraf , preevy down might seem to stop the services and keep the machine.

For backwards-compat, keep down as an alias

Documenting an internal discussion:

  • If we have an up command, it makes sense that the opposite would be down, just like Docker Compose:
    • Docker Compose's down command stops and removes the containers - this is equivalent to Preevy's down command
    • Docker Compose's rm command removes stopped containers (and ignores running containers) - the suggested rm is not equivalent.
  • Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

Ah, this makes sense.

Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

Like this idea.

i am beginner in this filed but i can rename it.
so, only tell me, should i rename all the 'preevy down' to 'preevy rm'?