GCP Config Connector CRDs

Question

GCP Config Connector CRDs

adnaan opened this issue 2 years ago · comments

Hi ! First of all, great work with deploykit. I am quite aligned on this approach have been using deploykit's k8s generated API here: https://github.com/dxcfg/dxcfg.

I see a potential use case to provision GCP resources using config connector CRDs. Would you be open to a contribution for that ?

Yshayy · Answer 1 · Fri May 27 2022 16:30:01 GMT+0800 (China Standard Time)

Thanks for the feedback :)

Be happy to accept PR, you can add sources here:
https://github.com/livecycle/deploykit/blob/199e95f53a10182df410523fc8f64b73a4f3cde3/generated/k8s/sources.json
And run the generate script. (If it doesn’t work, I can apply it as well)

I’ll publish a new version after the PR is merged

Adnaan Badr · Answer 2 · Fri May 27 2022 16:35:15 GMT+0800 (China Standard Time)

Its actually is a lot of CRD yamls in there: https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/crds. And growing ! You are ok with the sources.json file getting a little crowded ? Alternatively I can keep it separate in its own json file.

Yshayy · Answer 3 · Fri May 27 2022 16:42:05 GMT+0800 (China Standard Time)

Hmm, maybe we can change the sources.json to sources.ts that exposes the sources object?
That way you can import other file that contains all the other crds and just “…” array spread it.

Adnaan Badr · Answer 4 · Fri May 27 2022 16:51:38 GMT+0800 (China Standard Time)

Makes sense. I will go with that.