ETS with Kino.DataTable broken?
BrooklinJazz opened this issue · comments
I've encountered an issue where :ets tables that used to display nicely in DockYard Academy don't anymore. DockYard-Academy/curriculum#710.
If I remember correctly, the key and the value of the inserted record used to be in their own column, but now it's squished into one column called "row".
It also seems like empty tables can no longer display. It will flash for a moment, then disappear.
I can create a new table, insert an element, then render it, and it works fine though.
I'm using kino 0.8 and livebook 0.8. Am I doing something wrong, or can others reproduce this issue? Thank you!
Also, I think this is a Kino issue, since this feature comes with kino, not livebook, by default. But if you'd prefer these kinds of issues be raised in the Livebook repo let me know and I'm happy to adjust 🙏
The moving to row is expected because ets rows don't have a predetermined size, unfortunately. However, I think we should expand the whole row if there is space and empty tables should not flash. Thanks for the report. :)
It also seems like empty tables can no longer display. It will flash for a moment, then disappear.
@BrooklinJazz, could you please test it from main? Coz I think it's already fixed, just not yet released.
Absolutely. Will test and verify.
@BrooklinJazz the main version plus #247 should solve everything. Please, let me know!
@cristineguadelupe Yup! Verified it's working. Feel free to close.
The row is still squished, but I think that's a livebook problem, not a kino problem.
Should I raise an issue there?
Squished row is fixed by #247.