Suggestion: update height to 0 when it closes

Question

Suggestion: update height to 0 when it closes

davecoffin opened this issue 4 years ago · comments

Dave Coffin commented 4 years ago

This is a helpful plugin, but it would be awesome if an event was thrown when the keyboard height changes to 0!

liuy97 · Answer 1 · Sat Jan 02 2021 21:45:40 GMT+0800 (China Standard Time)

All height changes will trigger SoftKeyboardCallback. You can check 0 height there. Does it not work for you?

Dave Coffin · Answer 2 · Sat Jan 02 2021 22:47:49 GMT+0800 (China Standard Time)

No, dismissing the keyboard doesn’t trigger the height change event. I would think it should trigger a change event and the result be 0, but no event is fired.

liuy97 · Answer 3 · Mon Jan 04 2021 23:11:57 GMT+0800 (China Standard Time)

I cannot reproduce this bug. I confirmed I get 0-height in Android.

Dave Coffin · Answer 4 · Tue Jan 05 2021 01:56:27 GMT+0800 (China Standard Time)

Issue is on iOS.

Dave Coffin · Answer 5 · Wed Feb 03 2021 22:06:35 GMT+0800 (China Standard Time)

@oguzhanbolme Just follow the instructions:
https://github.com/liuy97/nativescript-soft-keyboard/tree/master/packages/soft-keyboard
registerSoftKeyboardCallback((h) => console.log(h)) h is the height.

achancu · Answer 6 · Thu Apr 14 2022 06:27:16 GMT+0800 (China Standard Time)

@davecoffin I've just created a PR that fixes this.

Dave Coffin · Answer 7 · Thu Apr 14 2022 07:30:16 GMT+0800 (China Standard Time)

You rock!!

achancu · Answer 8 · Thu Apr 14 2022 23:20:40 GMT+0800 (China Standard Time)

@davecoffin does it work for you?

liuy97 · Answer 9 · Tue Aug 30 2022 21:33:13 GMT+0800 (China Standard Time)

@achancu , thanks.
@davecoffin , I have confirmed that zero height is got. I add a sample in demo-angular.