little2s / NoChat

A lightweight chat UI framework for iOS.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Memory Leak or Retain Cycle

mbalex99 opened this issue · comments

It looks like there's a memory leak somewhere.

If you put

    deinit {
        print("Deinit Called")
    }

It never gets called in the demo project. There's some memory leak or strong retain cycle

Hi @mbalex99 ,
Memory problem is so bad, could you tell me this happening on which class? And more context about it?Thank you!

It's happening in all the demo controllers

You can out deinit in all demo controllers for TG, MM and SLK and find that
deinit is not called.

Thanks for your feedback, there is a retain cycle between ChatViewController and ChatInputViewController, I have fixed it on this commit 141d924. @mbalex99

Yes thank you so much!!!
On Wed, Jun 15, 2016 at 7:20 PM Yinglun Duan notifications@github.com
wrote:

Thanks for your feedback, there is a retain cycle between
ChatViewController and ChatInputViewController, I have fixed it on this
commit 141d924
141d924.
@mbalex99 https://github.com/mbalex99


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACFSMVsmkuV0_WCwdoSZgnAiw09mQOvYks5qMLLogaJpZM4I25EU
.

Maximilian Alexander
mbalex99@gmail.com
http://blog.edenmsg.com

Did you push to trunk for cocoapods or should I use this git branch?

This issue happened on Demo project, all of the pods need not to be changed. @mbalex99

Ah I'm sorry I realized just now thank you!