ENH: Handle Finviz night mode
VadimKovalchuk opened this issue · comments
Is your feature request related to a problem?
Failed to get stock fundamental data due to DOM change when Finviz automaticaly chalange UI with night mode
Describe the solution you'd like
Externally no changes should be observed
API breaking implications
No API change is required
Describe alternatives you've considered
Force day mode of handle night mode
Additional context
Night mode representation:
MSFT | Microsoft Corporation | [NASD] Technology | Software - Infrastructure | USA There is only 2 table rows (code calls for 3rd one)# Your code here, if applicable
#73 This will fix the issue. I will probably make a new release soon.
Should be fixed in #73. Release in v0.14.6rc1. Thanks for reporting.
Hello,
Is the bug still open or I'm missing something?
I tried to update to release v0.14.6rc1 (in the pycharm IDE) and got the following:
File "C:\Users~~~~~~~\PycharmProjects~~~~~~\venv\lib\site-packages\finvizfinance\quote.py", line 145, in ticker_fundament
(_, fundament_info["Company"], _) = rows[0].text.split(' | ')
ValueError: not enough values to unpack (expected 3, got 2)
Thank you lit26 for all your work
Yeah, there is still an issue. Fix soon.