alternative key for refresh

Question

alternative key for refresh

hoegge opened this issue 4 years ago · comments

Current behaviour

Currently you press '=' to refresh the view, which is ok on a US keyboard. But a lot of keyboard have '=' on a shifted key, so you have to press shift+key every time you refresh

Suggestion

Would you consider to change the shorcut key to <space> instead?

It much easier to hit and the same for all keyboard layouts.

PS: Thanks for the best docker GUI ever

Liran Tal · Answer 1 · Tue Apr 07 2020 14:05:29 GMT+0800 (China Standard Time)

That's a valid concern and I think that's a good idea too. Do you want to PR the change to the repo?

Morten H Pedersen · Answer 2 · Tue Apr 07 2020 16:51:57 GMT+0800 (China Standard Time)

OK - I'll try to see if I can figure it out and test it - brb

Morten H Pedersen · Answer 3 · Tue Apr 07 2020 19:58:10 GMT+0800 (China Standard Time)

Have changed it, run test and seems to work fine.

Morten H Pedersen · Answer 4 · Fri Apr 10 2020 19:48:29 GMT+0800 (China Standard Time)

Hi, Sorry for being ignorant. Do I need to do more to complete this (seems like the pull request went throug). Then I just close this issue (since it is assigned to me)?
Does it automatically update at NPM or do you have to do something for making a release?

Liran Tal · Answer 5 · Wed Apr 15 2020 01:59:15 GMT+0800 (China Standard Time)

@hoegge indeed, there was an issue with releasing a new version to npm. Looking into it now.

Liran Tal · Answer 6 · Wed Apr 15 2020 02:35:39 GMT+0800 (China Standard Time)

There we go, now there's a new dockly version released which should have this feature added.
Thanks for the ping @hoegge 👌