lirantal / dockly

Immersive terminal interface for managing docker containers and services

Home Page:https://lirantal.github.io/dockly/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extra green lines

art1415926535 opened this issue · comments

commented

Actual Behavior

I have 5 extra green lines at the bottom of the window.

image

Steps to Re-produce the Problem

  1. Install Dockly.
  2. Run Dockly from cmd.exe.

Context

  • Operating System: Windows 10
  • Node.js version (run node --version): v10.15.2
  • Package version: 3.10.5
  • Docker version (run docker --version): Docker version 18.03.0-ce, build 0520e24302
  • Is docker installed locally? Yes.
  • Does this file exists /var/run/docker.sock ? No.

I have that too (as in, it's expected :))

image

commented

Can I remove it to increase logs box?

Like this:
dockly-demo-2

I see what you mean but for the new version we use a layout system which really has just one block set for the toolbar but due to automatic positioning it's taking up the relevant space.

See:

const CONTAINERS_GRID_LAYOUT = {
  'actionsMenu': [4, 4, 4, 4],
  'searchInput': [11, 0, 1, 12],
  'actionStatus': [6, 0, 1, 10],
  'containerInfo': [2, 2, 8, 8],
  'containerList': [0, 0, 6, 10],
  'containerLogs': [7, 0, 4, 12],
  'containerStatus': [0, 10, 2, 2],
  'containerUtilization': [2, 10, 3, 2],
  'containerVsImages': [5, 10, 2, 2],
  'help': [4, 4, 4, 4],
  'toolbar': [11, 0, 1, 12]
}

If you're able to figure out better spacing I'm happy to merge a PR

@art1415926535 I'll close this issue out due to inactivity and currently no action planned on it. I'm also happy if you want to re-open and re-engage in the conversation on this!