lipanski / mockito

HTTP mocking for Rust!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why are you constraining the maximum version of `colored`

Nemo157 opened this issue · comments

I just noticed in the last docs.rs cargo update there was a downgrade of colored: rust-lang/docs.rs#2426

This is from #191 restricting the version constraint to colored = ">=2.0.0, <2.1.0", but there doesn't seem to be any mention of why the 2.1 versions can't be used. This isn't causing problems right now, but is likely to cause issues in the future if other crates depend on >=2.1.0 at some point.

They bumped their MSRV to 1.70 in 2.1.0 and I didn't want to change that yet (mockito supports 1.68 atm). Will probably follow soon or as soon as there's breakage. Is this an issue for you?

It's not an issue currently, I just wanted to make sure it didn't become an issue. The recommendation for supporting a more restrictive MSRV than your dependencies is to not constrain verisons but instead test with a set of locked dependencies to show that it is possible to compile with the MSRV while not stopping downstream users without such an MSRV requirement from using more recent versions.

Fair enough, I went the way to bumping the MSRV to 1.70 and dropping the version contraint - released in 1.4.0