Giters

linux-system-roles / network

An ansible role to configure networking

Home Page:https://linux-system-roles.github.io/network/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make verbose output optional

kwevers opened this issue · comments

commented

The final debug statement in the tasks file can cause very lengthy output on systems with a lot of interfaces or a lot of routes.
It would be nice to have the option to disable this output or to change the default so that it only displays stderr/stderr_lines.
Would a PR for this be welcomed and what would be the preferred behavior?

network/tasks/main.yml

Line 91 in 6fdac16

debug: var=__network_connections_result

commented

this is a valid point. Showing only stderr_lines by default seems like a good idea and the full output with an extra verbosity: 1 parameter so it requires ansible-playbook. What do you think about this? @richm what is your opinion?

commented

this is a valid point. Showing only stderr_lines by default seems like a good idea and the full output with an extra verbosity: 1 parameter so it requires ansible-playbook. What do you think about this? @richm what is your opinion?

I think showing stderr_lines by default, and requiring the user to specify extra verbosity, is a good idea. If there is already a mechanism in the network role by which the user can request extra verbosity, then I think you should use it.