Why is `helm repo update` called many times?

[Dylan Arbour]

On line 145 helm repo update is called many times, once for each repo. Would it not make sense to call once, after the loop of adds? Anything I'm missing?

concourse-helm-resource/assets/common.sh

Lines 133 to 146 in 0ce1523

 for r in $repos; do 
   name=$(echo $r | jq -r '.name') 
   url=$(echo $r | jq -r '.url') 
   username=$(echo $r | jq -r '.username // ""') 
   password=$(echo $r | jq -r '.password // ""') 
  
   echo Installing helm repository $name $url 
   if [[ -n "$username" && -n "$password" ]]; then 
     helm repo add $name $url --tiller-namespace $tiller_namespace --username $username --password $password 
   else 
     helm repo add $name $url --tiller-namespace $tiller_namespace 
   fi 
   helm repo update 
 done 

[Mario Siegenthaler]

Yeah, makes sense, no point in calling it many times.