linkyard / concourse-helm-resource

Deploy to kubernetes helm from your concourse.ci.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

hide option not working anymore.

maandr opened this issue · comments

Lately the hide option does not work for me anymore, even when providing new type: string along with it.

    - put: k8s
      params:
        chart: git/my-helm-chart
        values: git/my-helm-chart/values.yaml
        namespace: ((k8s_namespace))
        release: my-release
        override_values:
        - key: database.password
          value: ((database_password))
          type: string
          hide: true

This configuration still prints the values of database.password in the logs.

Oh, that happens on latest and 2.9.1-2, correct? Then it's probably a side-effect of the commit cfa5047 and the refactoring that was done there.

I'll look into it.

Yes, I first noticed it after cfa5047.

Thanks a lot!

Ah, it was renamed to 'hidden' in error. I reverted it back to 'hide' in commit f8346a. Now it should work again.
Could you test it with head (wait a bit for my change to be built)?

--set-string database.password=***HIDDEN*** 

Great. That fixed it. Thanks!