make lint

Question

make lint

craff opened this issue a year ago · comments

Christophe Raffalli commented a year ago

make lint is not configured in the same way as lint in the worflow ?
on my machine, make lint reports no error while the workflow fails with the same code.

Christophe Raffalli · Answer 1 · Sat Aug 05 2023 13:13:14 GMT+0800 (China Standard Time)

needed quite a lot of time to make lint happy because of this.

Christian Lindig · Answer 2 · Sat Aug 05 2023 23:55:48 GMT+0800 (China Standard Time)

I agree that the CI workflow is quite picky. I merged it recently from a PR and struggled with it, too. It has access to several OCaml releases, unlike the local installation. I am a bit torn whether to make the listing less struct. On the other hand, it is likely to help with submissions to Opam.

Christophe Raffalli · Answer 3 · Sun Aug 06 2023 04:03:35 GMT+0800 (China Standard Time)

I make lint would just do the same check, that will be ok for me. Le 5 août 2023 05:55:59 GMT-10:00, Christian Lindig ***@***.***> a écrit :

…

I agree that the CI workflow is quite picky. I merged it recently from a PR and struggled with it, too. It has access to several OCaml releases, unlike the local installation. I am a bit torn whether to make the listing less struct. On the other hand, it is likely to help with submissions to Opam. -- Reply to this email directly or view it on GitHub: #8 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

Török Edwin · Answer 4 · Sun Aug 06 2023 04:06:32 GMT+0800 (China Standard Time)

I think 'dune build @fmt' is missing from 'make lint' (there is an indent target in the Makefile though)

Christophe Raffalli · Answer 5 · Sun Aug 06 2023 07:02:54 GMT+0800 (China Standard Time)

in fact, make lint + make format is ok. Maybe make test could depend upon lint and format ?