Giters

lindell / multi-gitter

Update multiple repositories in with one command

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Installation fails with 404 on Windows

fabasoad opened this issue · comments

commented

Describe the bug
Installation fails with 404 on Windows.

To Reproduce
Steps to reproduce the behavior:

  1. On Windows run the command below.
curl -s https://raw.githubusercontent.com/lindell/multi-gitter/master/install.sh | sh -s -- -d v0.43.1
  1. See the following log output:
lindell/multi-gitter info checking GitHub for tag 'v0.43.1'
lindell/multi-gitter debug http_download https://github.com/lindell/multi-gitter/releases/v0.43.1
lindell/multi-gitter info found version: 0.43.1 for v0.43.1/Windows/x86_64
lindell/multi-gitter debug downloading files into /tmp/tmp.sxZiG8SCnq
lindell/multi-gitter debug http_download https://github.com/lindell/multi-gitter/releases/download/v0.43.1/multi-gitter_0.43.1_Windows_x86_64..exe
lindell/multi-gitter debug http_download_curl received HTTP status 404

Expected behavior
Installation should passed successfully

Additional context
Probably it happens because of L105 that is changing format to .exe but all assets in release are in .tar.gz format.

commented

Hello! Honestly, I did not intend for this installation method to be used by Windows users. Having sh installed can't be super common?

Ofc if we can get it to work, it would be great! 😄
I think your observation about the .exe renaming is correct. But there should be other problems such as the installation directory. /usr/local/bin does not exist in windows, and there exists nothing similar except C:/Windows/System32 (if PATH is not modified), which is not really intended to install external programs?

But as a start, could you make this change locally and run it with cat install.sh | sh -s -- -d

commented

After removing adjust_format function and its calling here is what I have:

lindell/multi-gitter info checking GitHub for latest tag
lindell/multi-gitter debug http_download https://github.com/lindell/multi-gitter/releases/latest
lindell/multi-gitter info found version: 0.43.2 for v0.43.2/Windows/x86_64
lindell/multi-gitter debug downloading files into /tmp/tmp.uQA7[5](https://github.com/lindell/multi-gitter/actions/runs/3479890976/jobs/5818994252#step:3:6)KtuI5
lindell/multi-gitter debug http_download https://github.com/lindell/multi-gitter/releases/download/v0.43.2/multi-gitter_0.43.2_Windows_x8[6](https://github.com/lindell/multi-gitter/actions/runs/3479890976/jobs/5818994252#step:3:7)_64.tar.gz
lindell/multi-gitter debug http_download https://github.com/lindell/multi-gitter/releases/download/v0.43.2/checksums.txt
lindell/multi-gitter info not allowed to install binary without higher privilege
main: line 61: sudo: command not found

I will try to look into it and will try to fix it. But generally I think either install.sh should be fixed or removed windows "support" from it as it is confusing at this moment.

Ofc if we can get it to work, it would be great! 😄

Agree. At first it is better to attempt to fix it 😃 I will look into it.

commented

Included in release v0.43.3 🎉