linagora / jmap-client

This repository provides a javascript lib to make requests against a JMAP server.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adapt AuthAccess model to new JMAP endpoint properties

thomascube opened this issue · comments

Apparently the JMAP spec recently changed the authentication complete response to use an "Url" suffix for URL properties. Therefore the according model should be adapted to keep up with the spec.

Right Thomas, thx for reporting.
Are you willing to submit a PR for this?

Yes, I can take that but it may take a few days until I find time to do it. I just created the issue first in order to not forget about it :-)

The latest JMAP spec also lists additional properties for the AuthAccess model: username, versions, extenstions. Should these become required properties as well? Or shall we keep them optional for better backwards compatibility?

Personally, I'd make username mandatory and treat versions and extensions optionally as they likely are empty anyways.

Yeah, I'm OK with your suggestion.

Fixed by #41