Change the default position of pop-up windows
maccagnan opened this issue · comments
Suggested improvement.
Change the default position of pop-up windows (search & replace, go to page, go to scene, etc.) so that they do not cover the text on the page. A window could 'remember' the last position when activated again or simply be positiones on the side.
Is this position good?
That's a static location, or is it movable by the user?
It is movable, but it does not save the position
@maccagnan what do you think? Seems like a solid improvement to me.
@Cerabbite What do you mean by 'it doesn't save the position'?
If that is the new default position it'd be great. It could save the last position used too, but that'd be a plus IMHO.
That is the new position, but it does not save the last position the user left it in.
Definite Improvement.
Then I say let's go with it for now.
I will have to make sure that all popups are in that position, and than I will create the pull request
These are the popups I found (if I missed some please let me know):
- Settings Dialog
- Find and Replace
- Auto-completion
- Headers
- Locations (Trying to open this gives me this error: TypeError: deepcopy() takes 1 positional argument but 2 were given)
- Title Pages
- Spell checker dictionary
- Report type
- Character map
- Watermarked PDF's generator
- Commands
Do we want all of these to be in the top left corner or can some stay in the middle?
I'd say all in the top left corner since the page will be normally showing the screenplay.
I opened a pull request (#50 ), I believe I have all the popups in the top left corner now. If you find one that is still in the center please let me know.
@Cerabbite I just released 2.4.8 and at least Find is still centered.
Weird, could you send a screenshot? On my device it is not centered
I'll take a look to see if I can solve the problem but for me it is not centered
Could you check for other dialogs? If they are all centered it could be, because the default popup position on Linux is center and on windows in the top right corner
Yeah, they're all centered and immobile.
Thanks for letting me know, I'll see how I can fix it
This is where I have positioned it right now. What I have changed is that instead of placing it in the default location I now place it 80 by 80 pixels from the topleft corner of the window. Note: This is currently only implemented in the find dialog. Link to PR
Still centered for me:
I don't know if this is helpful, but back on Trelby 2.3 (python2) changing the Find window's position would work on a virtual machine but the same modification would not work on an installed distro.
Interesting
@Cerabbite any updates on this?
No, from everything that I could find my code should work on Linux. At the moment I am spread very thin, so once I have more time I will take a look at this again to see if I can finally solve it
No worries, thanks!
Hello! This repository is merging into https://github.com/trelby/trelby.
Please check your issue against the current code there. If the issue is still relevant, please open a version of this issue there and close this issue. If not, just close this issue.
All issues in this repository that are still open in 30 days will be closed. Thank you!