[3.x] WebTestCase and FixturesTrait override (?)

Question

[3.x] WebTestCase and FixturesTrait override (?)

magnetik opened this issue 5 years ago · comments

Baptiste Lafontaine commented 5 years ago

After upgrading from 2.x, I'm confused by the fact that WebTestCase and FixturesTrait are sharing a lot of code, and defining a lot of properties and method.

It looks like both bundle are really really coupled and I'm quite sure that this will lead to breaking sooner or later.

Alexis Lefebvre · Answer 1 · Tue Jul 02 2019 16:58:27 GMT+0800 (China Standard Time)

I agree.

Some properties are not used and can be removed from FixturesTrait:https://github.com/liip/LiipTestFixturesBundle/blob/9bd069ffb892d47f2a00861de69a699bd49b7dbe/src/Test/FixturesTrait.php#L29

My biggest concern is getContainer() that is duplicated, we may deprecate it and recommend to inject dependencies instead: liip/LiipTestFixturesBundle#18

Tarjei Huse · Answer 2 · Wed Aug 05 2020 13:55:03 GMT+0800 (China Standard Time)

Should this issue be closed?

Alexis Lefebvre · Answer 3 · Wed Aug 05 2020 18:33:40 GMT+0800 (China Standard Time)

LiipFunctionalTestBundle and LiipTestFixturesBundle still define a getContainer() method. We don't have a solution yet.

Alexis Lefebvre · Answer 4 · Fri Jan 07 2022 22:24:22 GMT+0800 (China Standard Time)

It has been fixed in liip/LiipTestFixturesBundle#26

LiipTestFixturesBundle 2.x doesn't use a trait so there will be less conflicts.