Giters

life-itself / web3

Making sense of web3 & crypto. Introduction to key concepts and ideas. Rigorous, constructive analysis of key claims pro and con. A look at the deeper hopes and aspirations.

Home Page:https://web3.lifeitself.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Set home page social preview image as default for all pages

rufuspollock opened this issue · comments

commented

Configure the SEO stuff so that the social preview image (og:image i think) defaults to:

  • frontmatter image attribute if set
  • the default social preview image (the one for the home page which is set in siteConfig.js

Acceptance

Currently e.g. yields nothing whilst https://socialsharepreview.com/?url=https://web3.lifeitself.us/ works.

Also this one which should have a frontmatter image shows nothing.

Tasks

  • All other Pages without frontmatter image shows default social preview of homepage (siteconfig)
  • Deep dive pages -
    • pages with frontmatter image for social preview
    • pages without frontmatter image but with youtube shows youtube thumbnail image
      • src for image is https://img.youtube.com/vi/<youtube-video-id>/maxresdefault.jpg
    • defaults to homepage image if no frontmatter image and/or youtube is set
commented

@khalilcodes you have marked as closed but https://socialsharepreview.com/?url=https://web3.lifeitself.us/notes/are-crypto-tokens-securities and there is no image showing up. Does it work for you?

Also as a comment: the done on acceptance criteria can be for the acceptance criteria. E.g. here the tasks are about implmentation whereas acceptance were about outcomes - so referencing the tasks does not make as much sense. The acceptance criteria done would be something like "Working. See preview link" (or even pasting a screenshot).

commented

@rufuspollock it's working on my end. Not sure, maybe socialshare sometimes doesn't detect as it didn't show up on first try ...

Also checked it on twitter too ...

Thanks for the comment, I will update the acceptance with these screenshots if solved.

commented

@khalilcodes great - so let's assume it works! (Worth noting things like you tried it in both places in acceptance (next time) -- v useful info).