PGN cleanup may break comments

Question

PGN cleanup may break comments

niklasf opened this issue 2 years ago · comments

It looks like these global replacements are intended to gracefully deal with invalid PGNs enclosed in [pgn]...[/pgn], using non-ASCII dashes in O-O and O-O-O, and en passant captures like exd6 e.p.. But they would also incorrectly modify comments.

https://github.com/ornicar/scalachess/blob/6e6062fd3f9ddba870051ceaf9e47b87733a7d2d/src/main/scala/format/pgn/Parser.scala#L24-L28

Thanh Le · Answer 1 · Tue Jan 11 2022 23:38:17 GMT+0800 (China Standard Time)

I was wondering about this part as well. With the current implementation we don't really need this step.

Removing this step also helps us show the error location correctly. Now we can only show the location of the error in the pre-processed string, not for the whole original string.

I can work on this issue.