Giters

libsdl-org / SDL_image

Image decoding for many popular formats for Simple Directmedia Layer.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

testimage svg failures after commit 9f5859e

sezero opened this issue · comments

commented

Commit 9f5859e merged rounding changes from mainstream: memononen/nanosvg@b30716c and its follow-up memononen/nanosvg@cb0ae54 (memononen/nanosvg#247)

That resulted in testimage failures. The output files zipped + attached: outfiles-bmp.zip

The results seems visually same to me, but please have a look and advise
(github doesn't seem to allow bmp attachments, therefore they are converted
to png with 0-compression using gimp.) These results are from a run on an
i686-linux setup.

CC: @smcv, @slouken

ERROR: 10/25/23 13:59:33: Comparison of pixels with allowable error of 0 failed 125 times.
ERROR: 10/25/23 13:59:33: First detected occurrence at position 30,4 with a squared RGB-difference of 3.
ERROR: 10/25/23 13:59:33: Surfaces from failed comparison saved as 'CompareSurfaces0050_TestOutput.bmp' and 'CompareSurfaces0050_Reference.bmp'
ERROR: 10/25/23 13:59:33: Assert 'Surface differed from reference by at most 0 in 125 pixels': Failed
INFO: /tmp/SDL_image/test/svg-class.svg:
[...]

CompareSurfaces0050_Reference
CompareSurfaces0050_TestOutput

ERROR: 10/25/23 13:59:33: Comparison of pixels with allowable error of 0 failed 125 times.
ERROR: 10/25/23 13:59:33: First detected occurrence at position 30,4 with a squared RGB-difference of 3.
ERROR: 10/25/23 13:59:33: Surfaces from failed comparison saved as 'CompareSurfaces0051_TestOutput.bmp' and 'CompareSurfaces0051_Reference.bmp'
ERROR: 10/25/23 13:59:33: Assert 'Surface differed from reference by at most 0 in 125 pixels': Failed
INFO: /tmp/SDL_image/test/svg-class.svg:
[...]

CompareSurfaces0051_Reference
CompareSurfaces0051_TestOutput

ERROR: 10/25/23 13:59:33: Comparison of pixels with allowable error of 0 failed 125 times.
ERROR: 10/25/23 13:59:33: First detected occurrence at position 30,4 with a squared RGB-difference of 3.
ERROR: 10/25/23 13:59:33: Surfaces from failed comparison saved as 'CompareSurfaces0052_TestOutput.bmp' and 'CompareSurfaces0052_Reference.bmp'
ERROR: 10/25/23 13:59:33: Assert 'Surface differed from reference by at most 0 in 125 pixels': Failed
INFO: /tmp/SDL_image/test/svg-class.svg:
[...]

CompareSurfaces0052_Reference
CompareSurfaces0052_TestOutput

ERROR: 10/25/23 13:59:33: Comparison of pixels with allowable error of 0 failed 125 times.
ERROR: 10/25/23 13:59:33: First detected occurrence at position 30,4 with a squared RGB-difference of 3.
ERROR: 10/25/23 13:59:33: Surfaces from failed comparison saved as 'CompareSurfaces0053_TestOutput.bmp' and 'CompareSurfaces0053_Reference.bmp'
ERROR: 10/25/23 13:59:33: Assert 'Surface differed from reference by at most 0 in 125 pixels': Failed
INFO: /tmp/SDL_image/test/svg-class.svg:
[...]

CompareSurfaces0053_Reference
CompareSurfaces0053_TestOutput

commented

I think that's close enough, and it would make sense to consider this to be an intentional nanosvg change and update the expected bmps to match the real output.

commented

I think that's close enough, and it would make sense to consider this to be an intentional nanosvg change and update the expected bmps to match the real output.

Agreed.

commented

Updated reference svg-class.bmp in both SDL2 and SDL3 branches.