Add 0.5.1 zip to release
pietbrauer opened this issue · comments
In the most recent carthage release it is possible to attach zips. I tried to build it for 0.6.0 but it is not building because of a libssh2 error.
However I was able to build 0.5.1 and tried to attach it to this ticket, but it is 12,3 MB and Github only allows 10 MB. It would be so cool if I could attach it to the release 🐈
Many Thanks!
I've just invited you to be a collaborator. 😊
I uploaded the binary and since removed it again because the header search path is not working.
So everyone including this project via carthage will get the git2/filter.h file not found errors. Because obviously "$(SRCROOT)/Carthage/Checkouts/objective-git/External/libgit2/include/" does no longer exist.
Any idea?
Bleh, this is the problem that the module map is intended to solve, but that only came in 0.6.
Even with the module map it is not solved (tried with 0.6) and the mac build needs to set HEADER_SEARCH_PATHS too so it can't be an iOS configuration error. Any ideas?
Sorry, I don't have a whole lot of free time to investigate this, especially because ObjectiveGit is successfully building in our subproject setup. 😕
Sure, maybe @phatblat has an idea. He already had a fix every time I opened an issue 😃
Worked but had to add $(SRCROOT)/Carthage/Build/iOS/ObjectiveGit.framework/Headers/ to HEADER_SEARCH_PATHS
I wonder if we could fix that by using angle-bracket imports in the module map? Anyways, glad to hear it's working now.
You mean like this? That doesn't work.
Ah, alright. 😞
Thanks for trying!
Add HEADER_SEARCH_PATHS do the trick. thanks @pietbrauer !