Outstanding performance improvements?
rmosolgo opened this issue · comments
I remember @arthurschreiber hunting some good performance wins on his own branch a loooong time ago, and I can't remember if the all got merged here, or if some of them are still in https://github.com/arthurschreiber/promise.rb/branches somewhere. Does anyone know?
cc @ahoglund, do you mind checking if GitHub still runs a custom sha of this library? (Or maybe it's running a Rubygems version by now, like I said, I can't remember...) Thanks!
@rmosolgo - github/github runs the promise.rb version as a dependency of graphql-batch. At this time those versions are:
graphql-batch (0.4.3.20.g211b11a)
┊ graphql (>= 1.3, < 2)
┊ promise.rb (~> 0.7.2)
#34 was an iteration on some of that performance work. Although, it looked like there was planned follow-up work on top, but not corresponding PR that I see
Ahh -- ok, thanks for sharing that detail, @ahoglund. It looks like that commit was released: Shopify/graphql-batch@211b11a (in GraphQL-Batch 0.5.0). So, I guess my memory was a bit out of date 😅 Thanks for looking into it!