Do not host PR preview on a production url
certik opened this issue · comments
Ondřej Čertík commented
The production url is: dev.lfortran.org
We should not use it to preview PRs, because I think it's more robust and cleaner to only deploy when merged into master.
Shaikh Ubaid commented
At present, we use the url https://lfortran.github.io/pull_request_preview to host PR previews. It is different from the production url https://dev.lforttran.org. Please, could you possibly share if this issue seems solved or if it safe to close.
Ondřej Čertík commented
Ah, that is different! In that case I think this issue is fixed. Thanks for already having it fixed. :)