Rename Fluxter.Batch

Question

Rename Fluxter.Batch

lexmag opened this issue 8 years ago · comments

I think it conveys incorrect meaning: collect several writes, not aggregate them into one.
@whatyouhide do you have any naming ideas? Fluxter.Total could work.

Andrea Leopardi · Answer 1 · Sun Oct 30 2016 04:01:17 GMT+0800 (China Standard Time)

I don't like Fluxter.Total personally as it doesn't say much on "total" of what, or how this "total" is calculated. Maybe something like Fluxter.LocalCounter? I'd like to try to convey the idea that 1. it's only for integers 2. it sums them and 3. it doesn't talk to InfluxDB until "flushed".

Andrea Leopardi · Answer 2 · Mon Nov 07 2016 20:00:05 GMT+0800 (China Standard Time)

Let's go with Fluxter.Counter and MyApp.Fluxter.start_counter, MyApp.Fluxter.increment_counter, MyApp.Fluxter.flush_counter.

Aleksei Magusev · Answer 3 · Fri Dec 23 2016 08:59:10 GMT+0800 (China Standard Time)

Closing in favor of the PR #10.